Add DISABLE-TX-SUB configuration parameter #4979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 79562fb.
Shaptic
reviewed
Aug 15, 2023
urvisavla
reviewed
Aug 15, 2023
urvisavla
reviewed
Aug 15, 2023
urvisavla
reviewed
Aug 15, 2023
sreuland
reviewed
Aug 21, 2023
sreuland
reviewed
Aug 21, 2023
…to add-tx-disabled
This makes it easy for us to check if the flag has been provided by the user or not.
sreuland
reviewed
Aug 28, 2023
sreuland
reviewed
Aug 28, 2023
sreuland
reviewed
Aug 28, 2023
sreuland
approved these changes
Aug 28, 2023
urvisavla
pushed a commit
to urvisavla/go
that referenced
this pull request
Aug 31, 2023
* Add DisableTxSub param * Add tests * Add test for ApplyFlags * Revert "Add tests" This reverts commit 79562fb. * Make changes - 1 * Update parameters_test.go * Add check for INGEST=false and refactor test for help output * Update integration.go * Check if integration tests have been enabled * Remove INGEST=false condition for tx-submission * Update flags.go * Make changes - 1 * Make changes - 2 * Make changes - 3 * Change type to String This makes it easy for us to check if the flag has been provided by the user or not. * Make changes - 4 * Add tests for different configurations of DISABLE_TX_SUB * Update parameters_test.go * Add integration tests checking transaction submission * Update txsub_test.go * Update parameters_test.go * Update parameters_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Closes #4914
DISABLE-TX-SUBparameter which disables transaction submission functionality for Horizon.Why
This change helps separate the transaction submission functionality of Horizon. If users want to just use Horizon as an API layer, they can switch off this functionality.
Known limitations
None